pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Etsuro Fujita <efujita@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove incorrect file reference in comment.
Date: Mon, 13 Nov 2023 10:14:02 +0000
Message-ID: <E1r2TxB-005DQs-PQ@gemulon.postgresql.org> (raw)

Remove incorrect file reference in comment.

Commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c,
but follow-up commit c91560def incorrectly updated this reference.  We
could fix it, but as pointed out by Daniel Gustafsson, 1) the reader can
easily find the file that contains the definition of that function, e.g.
by grepping, and 2) this kind of reference is prone to going stale; so
let's just remove it.

Back-patch to all supported branches.

Reviewed by Daniel Gustafsson.

Discussion: https://postgr.es/m/CAPmGK145VdKkPBLWS2urwhgsfidbSexwY-9zCL6xSUJH%2BBTUUg%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/06e8e71e7ffdaa50556f946c080a22040b8a4784

Modified Files
--------------
src/backend/storage/ipc/procarray.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)



view thread (6+ messages)

Message-ID: <E1r2TxB-005DQs-PQ@gemulon.postgresql.org>
Permalink:  ../E1r2TxB-005DQs-PQ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1r2TxB-005DQs-PQ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: efujita@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove incorrect file reference in comment.
  In-Reply-To: <E1r2TxB-005DQs-PQ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox