pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove incorrect file reference in comment. 6+ messages / 1 participants [nested] [flat]
* pgsql: Remove incorrect file reference in comment. @ 2023-11-13 10:14 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Etsuro Fujita @ 2023-11-13 10:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove incorrect file reference in comment. Commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up commit c91560def incorrectly updated this reference. We could fix it, but as pointed out by Daniel Gustafsson, 1) the reader can easily find the file that contains the definition of that function, e.g. by grepping, and 2) this kind of reference is prone to going stale; so let's just remove it. Back-patch to all supported branches. Reviewed by Daniel Gustafsson. Discussion: https://postgr.es/m/CAPmGK145VdKkPBLWS2urwhgsfidbSexwY-9zCL6xSUJH%2BBTUUg%40mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/06e8e71e7ffdaa50556f946c080a22040b8a4784 Modified Files -------------- src/backend/storage/ipc/procarray.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Remove incorrect file reference in comment. @ 2023-11-13 10:14 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Etsuro Fujita @ 2023-11-13 10:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove incorrect file reference in comment. Commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up commit c91560def incorrectly updated this reference. We could fix it, but as pointed out by Daniel Gustafsson, 1) the reader can easily find the file that contains the definition of that function, e.g. by grepping, and 2) this kind of reference is prone to going stale; so let's just remove it. Back-patch to all supported branches. Reviewed by Daniel Gustafsson. Discussion: https://postgr.es/m/CAPmGK145VdKkPBLWS2urwhgsfidbSexwY-9zCL6xSUJH%2BBTUUg%40mail.gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ee4fabfdab3625bb0b767a15c083b624be5c5af1 Modified Files -------------- src/backend/storage/ipc/procarray.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Remove incorrect file reference in comment. @ 2023-11-13 10:14 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Etsuro Fujita @ 2023-11-13 10:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove incorrect file reference in comment. Commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up commit c91560def incorrectly updated this reference. We could fix it, but as pointed out by Daniel Gustafsson, 1) the reader can easily find the file that contains the definition of that function, e.g. by grepping, and 2) this kind of reference is prone to going stale; so let's just remove it. Back-patch to all supported branches. Reviewed by Daniel Gustafsson. Discussion: https://postgr.es/m/CAPmGK145VdKkPBLWS2urwhgsfidbSexwY-9zCL6xSUJH%2BBTUUg%40mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c30f1fcd8abf25524120797dda3b7650231ca73c Modified Files -------------- src/backend/storage/ipc/procarray.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Remove incorrect file reference in comment. @ 2023-11-13 10:14 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Etsuro Fujita @ 2023-11-13 10:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove incorrect file reference in comment. Commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up commit c91560def incorrectly updated this reference. We could fix it, but as pointed out by Daniel Gustafsson, 1) the reader can easily find the file that contains the definition of that function, e.g. by grepping, and 2) this kind of reference is prone to going stale; so let's just remove it. Back-patch to all supported branches. Reviewed by Daniel Gustafsson. Discussion: https://postgr.es/m/CAPmGK145VdKkPBLWS2urwhgsfidbSexwY-9zCL6xSUJH%2BBTUUg%40mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c09e4fc01832abc1cc769bc933aa734d1e5ece8d Modified Files -------------- src/backend/storage/ipc/procarray.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Remove incorrect file reference in comment. @ 2023-11-13 10:14 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Etsuro Fujita @ 2023-11-13 10:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove incorrect file reference in comment. Commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up commit c91560def incorrectly updated this reference. We could fix it, but as pointed out by Daniel Gustafsson, 1) the reader can easily find the file that contains the definition of that function, e.g. by grepping, and 2) this kind of reference is prone to going stale; so let's just remove it. Back-patch to all supported branches. Reviewed by Daniel Gustafsson. Discussion: https://postgr.es/m/CAPmGK145VdKkPBLWS2urwhgsfidbSexwY-9zCL6xSUJH%2BBTUUg%40mail.gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d3d73e85aa30bbfffc27c5918d5092ab963fc0c4 Modified Files -------------- src/backend/storage/ipc/procarray.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Remove incorrect file reference in comment. @ 2023-11-13 10:14 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Etsuro Fujita @ 2023-11-13 10:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove incorrect file reference in comment. Commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up commit c91560def incorrectly updated this reference. We could fix it, but as pointed out by Daniel Gustafsson, 1) the reader can easily find the file that contains the definition of that function, e.g. by grepping, and 2) this kind of reference is prone to going stale; so let's just remove it. Back-patch to all supported branches. Reviewed by Daniel Gustafsson. Discussion: https://postgr.es/m/CAPmGK145VdKkPBLWS2urwhgsfidbSexwY-9zCL6xSUJH%2BBTUUg%40mail.gmail.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7b6ba8c4315e5657fd90bad91c552fca58dc87fd Modified Files -------------- src/backend/storage/ipc/procarray.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2023-11-13 10:14 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-11-13 10:14 pgsql: Remove incorrect file reference in comment. Etsuro Fujita <efujita@postgresql.org> 2023-11-13 10:14 pgsql: Remove incorrect file reference in comment. Etsuro Fujita <efujita@postgresql.org> 2023-11-13 10:14 pgsql: Remove incorrect file reference in comment. Etsuro Fujita <efujita@postgresql.org> 2023-11-13 10:14 pgsql: Remove incorrect file reference in comment. Etsuro Fujita <efujita@postgresql.org> 2023-11-13 10:14 pgsql: Remove incorrect file reference in comment. Etsuro Fujita <efujita@postgresql.org> 2023-11-13 10:14 pgsql: Remove incorrect file reference in comment. Etsuro Fujita <efujita@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox