From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Replace Gen_dummy_probes.sed with Gen_dummy_probes.pl
Date: Tue, 14 Nov 2023 09:32:11 +0000
Message-ID: <E1r2pmE-005Ojy-Ua@gemulon.postgresql.org> (raw)
Replace Gen_dummy_probes.sed with Gen_dummy_probes.pl
To generate a dummy probes.h file when dtrace is not available, we had
two different scripts: A sed version, which is the original version,
and a Perl version, which was generated by s2p. This split was
necessary because Perl was not a mandatory build dependency on Unix,
but sed was not guaranteed to be available on Windows.
(The Meson build system used the sed version even on Windows, which
was probably incorrect and probably would have had to be fixed before
elevating that build system from experimental status.)
As of 721856ff24, Perl is a required build dependency, so this split
is no longer necessary. We can just use the Perl script in all build
environments and remove a whole bunch of infrastructure to keep the
two variants in sync.
The new Gen_dummy_probes.pl is not the version generated by s2p but a
new implementation written by hand by adapting the sed version to Perl
syntax.
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://www.postgresql.org/message-id/3fd0f1bc-4483-4ba9-8aa0-64765b052039@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3849fe7c2ba7758eee5f1f524147a3620b677fb3
Modified Files
--------------
.gitattributes | 1 -
src/backend/utils/Gen_dummy_probes.pl | 275 +++------------------------
src/backend/utils/Gen_dummy_probes.pl.prolog | 19 --
src/backend/utils/Gen_dummy_probes.sed | 24 ---
src/backend/utils/Makefile | 15 +-
src/backend/utils/README.Gen_dummy_probes | 27 ---
src/include/utils/meson.build | 2 +-
src/tools/msvc/Solution.pm | 2 +-
8 files changed, 26 insertions(+), 339 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Replace Gen_dummy_probes.sed with Gen_dummy_probes.pl
In-Reply-To: <E1r2pmE-005Ojy-Ua@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox