pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Explicitly skip TAP tests under Meson if disabled
Date: Thu, 16 Nov 2023 07:18:48 +0000
Message-ID: <E1r3WeF-005gog-Qa@gemulon.postgresql.org> (raw)

Explicitly skip TAP tests under Meson if disabled

If the tap_tests option is disabled under Meson, the TAP tests are
currently not registered at all.  But this makes it harder to see what
is going on, why suddently there are fewer tests than before.

Instead, run testwrap with an option that marks the test as skipped.
That way, the total list and count of tests is constant whether the
option is enabled or not.

Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/ad5ec96d-69ec-317b-a137-367ea5019b61@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bc15a126bbab99aa12fe7138131c12d3674e2c94

Modified Files
--------------
meson.build        | 5 +++--
src/tools/testwrap | 5 +++++
2 files changed, 8 insertions(+), 2 deletions(-)



Message-ID: <E1r3WeF-005gog-Qa@gemulon.postgresql.org>
Permalink:  ../E1r3WeF-005gog-Qa@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1r3WeF-005gog-Qa@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Explicitly skip TAP tests under Meson if disabled
  In-Reply-To: <E1r3WeF-005gog-Qa@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox