From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Ensure we preprocess expressions before checking their volatilit
Date: Thu, 16 Nov 2023 15:05:29 +0000
Message-ID: <E1r3dvs-005jqR-Lz@gemulon.postgresql.org> (raw)
Ensure we preprocess expressions before checking their volatility.
contain_mutable_functions and contain_volatile_functions give
reliable answers only after expression preprocessing (specifically
eval_const_expressions). Some places understand this, but some did
not get the memo --- which is not entirely their fault, because the
problem is documented only in places far away from those functions.
Introduce wrapper functions that allow doing the right thing easily,
and add commentary in hopes of preventing future mistakes from
copy-and-paste of code that's only conditionally safe.
Two actual bugs of this ilk are fixed here. We failed to preprocess
column GENERATED expressions before checking mutability, so that the
code could fail to detect the use of a volatile function
default-argument expression, or it could reject a polymorphic function
that is actually immutable on the datatype of interest. Likewise,
column DEFAULT expressions weren't preprocessed before determining if
it's safe to apply the attmissingval mechanism. A false negative
would just result in an unnecessary table rewrite, but a false
positive could allow the attmissingval mechanism to be used in a case
where it should not be, resulting in unexpected initial values in a
new column.
In passing, re-order the steps in ComputePartitionAttrs so that its
checks for invalid column references are done before applying
expression_planner, rather than after. The previous coding would
not complain if a partition expression contains a disallowed column
reference that gets optimized away by constant folding, which seems
to me to be a behavior we do not want.
Per bug #18097 from Jim Keener. Back-patch to all supported versions.
Discussion: https://postgr.es/m/18097-ebb179674f22932f@postgresql.org
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5c11104c7d20abbf845a2f03435641f7c6bc67de
Modified Files
--------------
src/backend/catalog/heap.c | 7 +++-
src/backend/commands/copy.c | 6 ++-
src/backend/commands/indexcmds.c | 31 +-------------
src/backend/commands/tablecmds.c | 50 +++++++++++-----------
src/backend/optimizer/util/clauses.c | 66 ++++++++++++++++++++++++++++++
src/include/optimizer/optimizer.h | 2 +
src/test/regress/expected/fast_default.out | 18 ++++++++
src/test/regress/expected/generated.out | 3 ++
src/test/regress/sql/fast_default.sql | 11 +++++
src/test/regress/sql/generated.sql | 3 ++
10 files changed, 141 insertions(+), 56 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Ensure we preprocess expressions before checking their volatilit
In-Reply-To: <E1r3dvs-005jqR-Lz@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox