pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove NOT_USED BufFileTellBlock() from buffile.c
Date: Fri, 17 Nov 2023 01:56:30 +0000
Message-ID: <E1r3o5u-005oOt-BV@gemulon.postgresql.org> (raw)

Remove NOT_USED BufFileTellBlock() from buffile.c

This routine has been marked as NOT_USED since 20ad43b576d9 from 2000,
and a patch is planned to switch the logtape/tuplestore APIs to rely on
int64 rather than long for the block nunbers, which is more portable.

Keeping it is more confusing than anything at this stage, so let's get
rid of it entirely.

Thanks for Heikki Linnakangas for the poke on this one.

Discussion: https://postgr.es/m/5047be8c-7ee6-4dd5-af76-6c916c3103b4@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c99c7a4871187a8bcf717147ff08e05a49e678d5

Modified Files
--------------
src/backend/storage/file/buffile.c | 18 ------------------
1 file changed, 18 deletions(-)



Message-ID: <E1r3o5u-005oOt-BV@gemulon.postgresql.org>
Permalink:  ../E1r3o5u-005oOt-BV@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1r3o5u-005oOt-BV@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove NOT_USED BufFileTellBlock() from buffile.c
  In-Reply-To: <E1r3o5u-005oOt-BV@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox