pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Prevent overflow for block number in buffile.c
Date: Mon, 20 Nov 2023 00:26:49 +0000
Message-ID: <E1r4s7l-006Hr7-AF@gemulon.postgresql.org> (raw)

Prevent overflow for block number in buffile.c

As coded, the start block calculated by BufFileAppend() would overflow
once more than 16k files are used with a default block size.  This issue
existed before b1e5c9fa9ac4, but there's no reason not to be clean about
it.

Per report from Coverity, with a fix suggested by Tom Lane.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3650e7a3933166b40f7f9043bd91f45d3467c74d

Modified Files
--------------
src/backend/storage/file/buffile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Message-ID: <E1r4s7l-006Hr7-AF@gemulon.postgresql.org>
Permalink:  ../E1r4s7l-006Hr7-AF@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1r4s7l-006Hr7-AF@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Prevent overflow for block number in buffile.c
  In-Reply-To: <E1r4s7l-006Hr7-AF@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox