pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix the initial sync tables with no columns.
Date: Wed, 22 Nov 2023 06:25:09 +0000
Message-ID: <E1r5gfd-006eJ6-5c@gemulon.postgresql.org> (raw)

Fix the initial sync tables with no columns.

The copy command formed for initial sync was using parenthesis for tables
with no columns leading to syntax error. This patch avoids adding
parenthesis for such tables.

Reported-by: Justin G
Author: Vignesh C
Reviewed-by: Peter Smith, Amit Kapila
Backpatch-through: 15
Discussion: http://postgr.es/m/18203-df37fe354b626670@postgresql.org

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1b6da28e0668eb977dcab6987d192ddedf32b752

Modified Files
--------------
src/backend/replication/logical/tablesync.c | 28 ++++++++++++++++++----------
src/test/subscription/t/001_rep_changes.pl  | 17 ++++++++++++++++-
2 files changed, 34 insertions(+), 11 deletions(-)



view thread (3+ messages)

Message-ID: <E1r5gfd-006eJ6-5c@gemulon.postgresql.org>
Permalink:  ../E1r5gfd-006eJ6-5c@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1r5gfd-006eJ6-5c@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix the initial sync tables with no columns.
  In-Reply-To: <E1r5gfd-006eJ6-5c@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox