From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Apply quotes more consistently to GUC names in logs
Date: Thu, 30 Nov 2023 05:12:01 +0000
Message-ID: <E1r8ZLF-007upD-Du@gemulon.postgresql.org> (raw)
Apply quotes more consistently to GUC names in logs
Quotes are applied to GUCs in a very inconsistent way across the code
base, with a mix of double quotes or no quotes used. This commit
removes double quotes around all the GUC names that are obviously
referred to as parameters with non-English words (use of underscore,
mixed case, etc).
This is the result of a discussion with Álvaro Herrera, Nathan Bossart,
Laurenz Albe, Peter Eisentraut, Tom Lane and Daniel Gustafsson.
Author: Peter Smith
Discussion: https://postgr.es/m/CAHut+Pv-kSN8SkxSdoHano_wPubqcg5789ejhCDZAcLFceBR-w@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8d9978a7176a2805a8188605de3c16ffc914dc8a
Modified Files
--------------
contrib/pg_prewarm/autoprewarm.c | 2 +-
src/backend/access/heap/vacuumlazy.c | 2 +-
src/backend/access/transam/commit_ts.c | 4 ++--
src/backend/access/transam/xlog.c | 4 ++--
src/backend/commands/vacuum.c | 2 +-
src/backend/commands/variable.c | 2 +-
src/backend/libpq/be-secure-openssl.c | 6 +++---
src/backend/postmaster/bgworker.c | 2 +-
src/backend/postmaster/checkpointer.c | 2 +-
src/backend/postmaster/pgarch.c | 2 +-
src/backend/storage/buffer/localbuf.c | 2 +-
src/backend/storage/file/fd.c | 2 +-
src/backend/storage/lmgr/predicate.c | 2 +-
src/backend/tcop/postgres.c | 10 +++++-----
src/backend/utils/adt/pg_locale.c | 4 ++--
src/backend/utils/fmgr/dfmgr.c | 4 ++--
src/backend/utils/misc/guc.c | 2 +-
src/backend/utils/misc/guc_tables.c | 4 ++--
src/test/modules/commit_ts/expected/commit_timestamp_1.out | 12 ++++++------
src/test/regress/expected/collate.icu.utf8.out | 4 ++--
src/test/regress/expected/json.out | 4 ++--
src/test/regress/expected/jsonb.out | 4 ++--
22 files changed, 41 insertions(+), 41 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Apply quotes more consistently to GUC names in logs
In-Reply-To: <E1r8ZLF-007upD-Du@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox