From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't try to open visibilitymap when analyzing a foreign table
Date: Fri, 08 Dec 2023 07:20:20 +0000
Message-ID: <E1rBV9o-009AE5-FH@gemulon.postgresql.org> (raw)
Don't try to open visibilitymap when analyzing a foreign table
It's harmless, visibilitymap_count() returns 0 if the file doesn't
exist. But it's also very pointless. I noticed this when I added an
assertion in smgropen() that the relnumber is valid.
Discussion: https://www.postgresql.org/message-id/621a52fd-3cd8-4f5d-a561-d510b853bbaf@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/049ef3398d05c9dc8f48aa9a6d68440661cfeb87
Modified Files
--------------
src/backend/commands/analyze.c | 5 ++++-
src/backend/storage/smgr/smgr.c | 2 ++
2 files changed, 6 insertions(+), 1 deletion(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Don't try to open visibilitymap when analyzing a foreign table
In-Reply-To: <E1rBV9o-009AE5-FH@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox