pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix description of I/O timing info for shared buffers in EXPLAIN
Date: Thu, 14 Dec 2023 09:00:27 +0000
Message-ID: <E1rDhZz-00A8hX-AQ@gemulon.postgresql.org> (raw)

Fix description of I/O timing info for shared buffers in EXPLAIN (BUFFERS)

This fixes an error introduced by efb0ef909f60, that changed the
description of this field to "shared/local" while these I/O timings
relate to shared buffers.  This information is available when
track_io_timing is enabled.  Note that HEAD has added new counters for
local buffers in 295c36c0c1fa, so there is no need to touch it.  The
description is updated to "shared" to be compatible with HEAD.

Per discussion with Nazir Bilal Yavuz and Hubert Depesz Lubaczewski,
whose EXPLAIN analyzer tool was not actually able to parse the previous
term because of the slash character.

Discussion: https://postgr.es/m/ZTCTiUqm_H3iBihl@paquier.xyz
Backpatch-through: 15

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/db69101a1d000d857a552e16e45f601adbb4dbc6

Modified Files
--------------
src/backend/commands/explain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1rDhZz-00A8hX-AQ@gemulon.postgresql.org>
Permalink:  ../E1rDhZz-00A8hX-AQ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rDhZz-00A8hX-AQ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix description of I/O timing info for shared buffers in EXPLAIN
  In-Reply-To: <E1rDhZz-00A8hX-AQ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox