From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned
Date: Tue, 19 Dec 2023 06:21:28 +0000
Message-ID: <E1rFTTr-00Asl0-LD@gemulon.postgresql.org> (raw)
pgstattuple: Fix failure with pgstathashindex() for partitioned indexes
As coded, the function relied on index_open() when opening an index
relation, allowing partitioned indexes to be processed by
pgstathashindex(). This was leading to a "could not open file" error
because partitioned indexes have no physical files, or to a crash with
an assertion failure (like on HEAD).
This issue is fixed by applying the same checks as the other stat
functions for indexes, with a lookup at both RELKIND_INDEX and the index
AM expected.
Author: Alexander Lakhin
Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org
Backpatch-through: 12
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b745f168042e253e92a71bb4d4554789d72c21c5
Modified Files
--------------
contrib/pgstattuple/expected/pgstattuple.out | 11 +++++++----
contrib/pgstattuple/pgstatindex.c | 5 ++---
contrib/pgstattuple/sql/pgstattuple.sql | 2 ++
3 files changed, 11 insertions(+), 7 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned
In-Reply-To: <E1rFTTr-00Asl0-LD@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox