pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned 6+ messages / 1 participants [nested] [flat]
* pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned @ 2023-12-19 06:21 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2023-12-19 06:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pgstattuple: Fix failure with pgstathashindex() for partitioned indexes As coded, the function relied on index_open() when opening an index relation, allowing partitioned indexes to be processed by pgstathashindex(). This was leading to a "could not open file" error because partitioned indexes have no physical files, or to a crash with an assertion failure (like on HEAD). This issue is fixed by applying the same checks as the other stat functions for indexes, with a lookup at both RELKIND_INDEX and the index AM expected. Author: Alexander Lakhin Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org Backpatch-through: 12 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/a8dd62ef4959141e410278fd68b3d1821e0bbbaa Modified Files -------------- contrib/pgstattuple/expected/pgstattuple.out | 11 +++++++---- contrib/pgstattuple/pgstatindex.c | 5 ++--- contrib/pgstattuple/sql/pgstattuple.sql | 2 ++ 3 files changed, 11 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned @ 2023-12-19 06:21 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2023-12-19 06:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pgstattuple: Fix failure with pgstathashindex() for partitioned indexes As coded, the function relied on index_open() when opening an index relation, allowing partitioned indexes to be processed by pgstathashindex(). This was leading to a "could not open file" error because partitioned indexes have no physical files, or to a crash with an assertion failure (like on HEAD). This issue is fixed by applying the same checks as the other stat functions for indexes, with a lookup at both RELKIND_INDEX and the index AM expected. Author: Alexander Lakhin Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org Backpatch-through: 12 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b4948ed66695a8455f8c1ade095b039324617a25 Modified Files -------------- contrib/pgstattuple/expected/pgstattuple.out | 11 +++++++---- contrib/pgstattuple/pgstatindex.c | 5 ++--- contrib/pgstattuple/sql/pgstattuple.sql | 2 ++ 3 files changed, 11 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned @ 2023-12-19 06:21 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2023-12-19 06:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pgstattuple: Fix failure with pgstathashindex() for partitioned indexes As coded, the function relied on index_open() when opening an index relation, allowing partitioned indexes to be processed by pgstathashindex(). This was leading to a "could not open file" error because partitioned indexes have no physical files, or to a crash with an assertion failure (like on HEAD). This issue is fixed by applying the same checks as the other stat functions for indexes, with a lookup at both RELKIND_INDEX and the index AM expected. Author: Alexander Lakhin Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org Backpatch-through: 12 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b745f168042e253e92a71bb4d4554789d72c21c5 Modified Files -------------- contrib/pgstattuple/expected/pgstattuple.out | 11 +++++++---- contrib/pgstattuple/pgstatindex.c | 5 ++--- contrib/pgstattuple/sql/pgstattuple.sql | 2 ++ 3 files changed, 11 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned @ 2023-12-19 06:21 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2023-12-19 06:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pgstattuple: Fix failure with pgstathashindex() for partitioned indexes As coded, the function relied on index_open() when opening an index relation, allowing partitioned indexes to be processed by pgstathashindex(). This was leading to a "could not open file" error because partitioned indexes have no physical files, or to a crash with an assertion failure (like on HEAD). This issue is fixed by applying the same checks as the other stat functions for indexes, with a lookup at both RELKIND_INDEX and the index AM expected. Author: Alexander Lakhin Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org Backpatch-through: 12 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f729fdab450f3429530e7566d50bd0fcf8343966 Modified Files -------------- contrib/pgstattuple/expected/pgstattuple.out | 11 +++++++---- contrib/pgstattuple/pgstatindex.c | 5 ++--- contrib/pgstattuple/sql/pgstattuple.sql | 2 ++ 3 files changed, 11 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned @ 2023-12-19 06:21 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2023-12-19 06:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pgstattuple: Fix failure with pgstathashindex() for partitioned indexes As coded, the function relied on index_open() when opening an index relation, allowing partitioned indexes to be processed by pgstathashindex(). This was leading to a "could not open file" error because partitioned indexes have no physical files, or to a crash with an assertion failure (like on HEAD). This issue is fixed by applying the same checks as the other stat functions for indexes, with a lookup at both RELKIND_INDEX and the index AM expected. Author: Alexander Lakhin Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org Backpatch-through: 12 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b4c1d255c17c2f004dcfbeeae11529271c18624c Modified Files -------------- contrib/pgstattuple/expected/pgstattuple.out | 11 +++++++---- contrib/pgstattuple/pgstatindex.c | 5 ++--- contrib/pgstattuple/sql/pgstattuple.sql | 2 ++ 3 files changed, 11 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned @ 2023-12-19 06:21 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2023-12-19 06:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pgstattuple: Fix failure with pgstathashindex() for partitioned indexes As coded, the function relied on index_open() when opening an index relation, allowing partitioned indexes to be processed by pgstathashindex(). This was leading to a "could not open file" error because partitioned indexes have no physical files, or to a crash with an assertion failure (like on HEAD). This issue is fixed by applying the same checks as the other stat functions for indexes, with a lookup at both RELKIND_INDEX and the index AM expected. Author: Alexander Lakhin Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org Backpatch-through: 12 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bd2d3c92812f617ebc9b826484fb0d0345571d17 Modified Files -------------- contrib/pgstattuple/expected/pgstattuple.out | 11 +++++++---- contrib/pgstattuple/pgstatindex.c | 5 ++--- contrib/pgstattuple/sql/pgstattuple.sql | 2 ++ 3 files changed, 11 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2023-12-19 06:21 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-12-19 06:21 pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned Michael Paquier <michael@paquier.xyz> 2023-12-19 06:21 pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned Michael Paquier <michael@paquier.xyz> 2023-12-19 06:21 pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned Michael Paquier <michael@paquier.xyz> 2023-12-19 06:21 pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned Michael Paquier <michael@paquier.xyz> 2023-12-19 06:21 pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned Michael Paquier <michael@paquier.xyz> 2023-12-19 06:21 pgsql: pgstattuple: Fix failure with pgstathashindex() for partitioned Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox