From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Enhance checkpointer restartpoint statistics
Date: Sun, 24 Dec 2023 23:13:11 +0000
Message-ID: <E1rHXeg-00Bl0i-Uw@gemulon.postgresql.org> (raw)
Enhance checkpointer restartpoint statistics
Bhis commit introduces enhancements to the pg_stat_checkpointer view by adding
three new columns: restartpoints_timed, restartpoints_req, and
restartpoints_done. These additions aim to improve the visibility and
monitoring of restartpoint processes on replicas.
Previously, it was challenging to differentiate between successful and failed
restartpoint requests. This limitation arises because restartpoints on replicas
are dependent on checkpoint records from the primary, and cannot occur more
frequently than these checkpoints.
The new columns allow for clear distinction and tracking of restartpoint
requests, their triggers, and successful completions. This enhancement aids
database administrators and developers in better understanding and diagnosing
issues related to restartpoint behavior, particularly in scenarios where
restartpoint requests may fail.
System catalog is changed. Catversion is bumped.
Discussion: https://postgr.es/m/99b2ccd1-a77a-962a-0837-191cdf56c2b9%40inbox.ru
Author: Anton A. Melnikov
Reviewed-by: Kyotaro Horiguchi, Alexander Korotkov
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/12915a58eec962f407a6c38ce2bf08a48dde57b5
Modified Files
--------------
doc/src/sgml/monitoring.sgml | 27 ++++++++++++++++
doc/src/sgml/wal.sgml | 39 ++++++++++++++++++++----
src/backend/catalog/system_views.sql | 3 ++
src/backend/postmaster/checkpointer.c | 27 ++++++++++++++--
src/backend/utils/activity/pgstat_checkpointer.c | 6 ++++
src/backend/utils/adt/pgstatfuncs.c | 18 +++++++++++
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.dat | 15 +++++++++
src/include/pgstat.h | 3 ++
src/test/regress/expected/rules.out | 3 ++
10 files changed, 134 insertions(+), 9 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Enhance checkpointer restartpoint statistics
In-Reply-To: <E1rHXeg-00Bl0i-Uw@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox