From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove BTScanOpaqueData.firstPage
Date: Wed, 27 Dec 2023 12:35:22 +0000
Message-ID: <E1rIT86-00C9Lm-EZ@gemulon.postgresql.org> (raw)
Remove BTScanOpaqueData.firstPage
It's not necessary to keep the firstPage flag as a field of BTScanOpaqueData.
This commit makes it an argument of the _bt_readpage() function. We can easily
distinguish first-time and repeated calls (within the scan) of this function.
Reported-by: Peter Geoghegan
Discussion: https://postgr.es/m/CAH2-Wzk4SOsw%2BtHuTFiz8U9Jqj-R77rYPkhWKODCBb1mdHACXA%40mail.gmail.com
Reviewed-by: Pavel Borisov
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/06b10f80ba4db745f21847520b07b4ffad814313
Modified Files
--------------
src/backend/access/nbtree/nbtree.c | 1 -
src/backend/access/nbtree/nbtsearch.c | 18 ++++++++----------
src/include/access/nbtree.h | 3 ---
3 files changed, 8 insertions(+), 14 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove BTScanOpaqueData.firstPage
In-Reply-To: <E1rIT86-00C9Lm-EZ@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox