From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix another incorrect data type choice from commit dc2123400.
Date: Wed, 27 Dec 2023 18:05:31 +0000
Message-ID: <E1rIYHb-00CBpH-GK@gemulon.postgresql.org> (raw)
Fix another incorrect data type choice from commit dc2123400.
add_file_to_manifest declared its mtime argument as pg_time_t,
apparently on the principle that copy-and-paste from the backend
is fine. However, the callers are passing struct stat's st_mtime
field which is plain time_t, and add_file_to_manifest itself is
passing the value to gmtime(3) which expects plain time_t,
so the whole thing would not work at all on any platform where
those types are different. Fortunately we can just switch this
variable to time_t.
Per warnings from assorted buildfarm members.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3f1fd416316cbb66de61ac1ac34839f025b0b242
Modified Files
--------------
src/bin/pg_combinebackup/write_manifest.c | 2 +-
src/bin/pg_combinebackup/write_manifest.h | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix another incorrect data type choice from commit dc2123400.
In-Reply-To: <E1rIYHb-00CBpH-GK@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox