From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't send "cannot connect" errors on invalid startup packet
Date: Sat, 30 Dec 2023 20:20:31 +0000
Message-ID: <E1rJfot-00CgpS-HX@gemulon.postgresql.org> (raw)
Don't send "cannot connect" errors on invalid startup packet
Commit 16671ba6e7 moved the code that sends "sorry, too many clients
already" and other such messages, but it had the effect that we would
send that error even if the the startup packet processing failed, e.g.
because the client sent an invalid startup packet. That was not
intentional.
Spotted while reading the code again.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5632d6e18a8afd586a99f680eddddc38b4ead769
Modified Files
--------------
src/backend/postmaster/postmaster.c | 65 +++++++++++++++++++------------------
1 file changed, 34 insertions(+), 31 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Don't send "cannot connect" errors on invalid startup packet
In-Reply-To: <E1rJfot-00CgpS-HX@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox