From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Minor cleanup of the BRIN parallel build code
Date: Sat, 30 Dec 2023 22:16:01 +0000
Message-ID: <E1rJhce-00Chkq-QK@gemulon.postgresql.org> (raw)
Minor cleanup of the BRIN parallel build code
Commit b437571714 added support for parallel builds for BRIN indexes,
using code similar to BTREE parallel builds, and also a new tuplesort
variant. This commit simplifies the new code in two ways:
* The "spool" grouping tuplesort and the heap/index is not necessary.
The heap/index are available as separate arguments, causing confusion.
So remove the spool, and use the tuplesort directly.
* The new tuplesort variant does not need the heap/index, as it sorts
simply by the range block number, without accessing the tuple data.
So simplify that too.
Initial report and patch by Ranier Vilela, further cleanup by me.
Author: Ranier Vilela
Discussion: https://postgr.es/m/CAEudQAqD7f2i4iyEaAz-5o-bf6zXVX-AkNUBm-YjUXEemaEh6A%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6c63bcbf3ccf555f02a8fd8b2acaf01a6e94cb97
Modified Files
--------------
src/backend/access/brin/brin.c | 98 +++++++++++-------------------
src/backend/utils/sort/tuplesortvariants.c | 26 +-------
src/include/utils/tuplesort.h | 4 +-
src/tools/pgindent/typedefs.list | 1 -
4 files changed, 39 insertions(+), 90 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Minor cleanup of the BRIN parallel build code
In-Reply-To: <E1rJhce-00Chkq-QK@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox