pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove unnecessary PGDATABASE settings from TAP tests
Date: Wed, 03 Jan 2024 01:28:38 +0000
Message-ID: <E1rKq3i-00DCqS-Ed@gemulon.postgresql.org> (raw)

Remove unnecessary PGDATABASE settings from TAP tests

Some of the TAP tests have been historically setting the environment
variable PGDATABASE to 'postgres', which is not needed because
PostgreSQL::Test::Cluster already sets it when initialized.  This commit
removes these explicit setups.

Note that the dependency of cluster -a with PGDATABASE (from
1caef31d9e55) is still documented.

Author: Bharath Rupireddy
Discussion: https://postgr.es/m/CALj2ACXLAz5dW3ZP+Fec8g6jQMMmDyCVT+qdbye2h7QJJmhsdw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4b66d7b4e0b3bb55c04fe9466b428c24d7cb0980

Modified Files
--------------
src/bin/scripts/t/011_clusterdb_all.pl     | 6 ++----
src/test/recovery/t/004_timeline_switch.pl | 2 --
src/test/recovery/t/019_replslot_limit.pl  | 2 --
3 files changed, 2 insertions(+), 8 deletions(-)



Message-ID: <E1rKq3i-00DCqS-Ed@gemulon.postgresql.org>
Permalink:  ../E1rKq3i-00DCqS-Ed@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rKq3i-00DCqS-Ed@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove unnecessary PGDATABASE settings from TAP tests
  In-Reply-To: <E1rKq3i-00DCqS-Ed@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox