pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Clean up some edge cases in plpgsql's %TYPE parsing.
Date: Fri, 05 Jan 2024 19:32:42 +0000
Message-ID: <E1rLpvu-0003OS-FJ@gemulon.postgresql.org> (raw)

Clean up some edge cases in plpgsql's %TYPE parsing.

Support referencing a composite-type variable in %TYPE.

Remove the undocumented, untested, and pretty useless ability
to have the subject of %TYPE be an (unqualified) type name.
You get the same result by just not writing %TYPE.

Add or adjust some test cases to improve code coverage here.

Discussion: https://postgr.es/m/716852.1704402127@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/43b46aae12b220b7eca8250c6c361083f35985a0

Modified Files
--------------
src/pl/plpgsql/src/expected/plpgsql_record.out | 46 +++++++++++++++++++
src/pl/plpgsql/src/pl_comp.c                   | 61 ++++++++++----------------
src/pl/plpgsql/src/sql/plpgsql_record.sql      | 40 +++++++++++++++++
src/test/regress/expected/plpgsql.out          | 10 ++---
src/test/regress/sql/plpgsql.sql               |  8 ++--
5 files changed, 119 insertions(+), 46 deletions(-)



Message-ID: <E1rLpvu-0003OS-FJ@gemulon.postgresql.org>
Permalink:  ../E1rLpvu-0003OS-FJ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rLpvu-0003OS-FJ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Clean up some edge cases in plpgsql's %TYPE parsing.
  In-Reply-To: <E1rLpvu-0003OS-FJ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox