pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix integer-overflow problem in intarray's g_int_decompress().
Date: Sun, 07 Jan 2024 20:20:03 +0000
Message-ID: <E1rMZcp-000Mkz-I0@gemulon.postgresql.org> (raw)

Fix integer-overflow problem in intarray's g_int_decompress().

An array element equal to INT_MAX gave this code indigestion,
causing an infinite loop that surely ended in SIGSEGV.  We fixed
some nearby problems awhile ago (cf 757c5182f) but missed this.

Report and diagnosis by Alexander Lakhin (bug #18273); patch by me

Discussion: https://postgr.es/m/18273-9a832d1da122600c@postgresql.org

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/940ab02b53eb3a3babc9dd4dea261f5a6d8aa334

Modified Files
--------------
contrib/intarray/_int_gist.c         | 10 ++++++----
contrib/intarray/data/test__int.data |  1 +
contrib/intarray/expected/_int.out   | 33 +++++++++++++++++----------------
contrib/intarray/sql/_int.sql        |  5 +++--
4 files changed, 27 insertions(+), 22 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1rMZcp-000Mkz-I0@gemulon.postgresql.org>
Permalink:  ../E1rMZcp-000Mkz-I0@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rMZcp-000Mkz-I0@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix integer-overflow problem in intarray's g_int_decompress().
  In-Reply-To: <E1rMZcp-000Mkz-I0@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox