From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Cross-check lists of predefined LWLocks.
Date: Tue, 09 Jan 2024 17:06:07 +0000
Message-ID: <E1rNFYF-000e29-UE@gemulon.postgresql.org> (raw)
Cross-check lists of predefined LWLocks.
Both lwlocknames.txt and wait_event_names.txt contain a list of all
the predefined LWLocks, i.e., those with predefined positions
within MainLWLockArray. It is easy to miss one or the other,
especially since the list in wait_event_names.txt omits the "Lock"
suffix from all the LWLock wait events. This commit adds a cross-
check of these lists to the script that generates lwlocknames.h.
If the lists do not match exactly, building will fail.
Suggested-by: Robert Haas
Reviewed-by: Robert Haas, Michael Paquier, Bertrand Drouvot
Discussion: https://postgr.es/m/20240102173120.GA1061678%40nathanxps13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5b1b9bce84497ec71dbd6d5a969e8fc5aa22b4ef
Modified Files
--------------
src/backend/Makefile | 2 +-
src/backend/storage/lmgr/Makefile | 4 +-
src/backend/storage/lmgr/generate-lwlocknames.pl | 49 ++++++++++++++++++++++++
src/backend/utils/activity/wait_event_names.txt | 12 ++++++
src/include/storage/meson.build | 4 +-
5 files changed, 67 insertions(+), 4 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Cross-check lists of predefined LWLocks.
In-Reply-To: <E1rNFYF-000e29-UE@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox