pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Handle WindowClause.runCondition in tree walker/mutator function 3+ messages / 1 participants [nested] [flat]
* pgsql: Handle WindowClause.runCondition in tree walker/mutator function @ 2024-01-10 18:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2024-01-10 18:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Handle WindowClause.runCondition in tree walker/mutator functions. Commit 9d9c02ccd, which added the notion of a "run condition" for window functions, neglected to teach nodeFuncs.c to process the new field. Remarkably, that doesn't seem to have had any ill effects before we invented Var.varnullingrels, but now it can cause visible failures in join-removal scenarios. I have no faith that there's not reachable problems in v15 too, so back-patch the code change to v15 where 9d9c02ccd came in. The test case seems irrelevant to v15, though. Per bug #18277 from Zuming Jiang. Diagnosis and patch by Richard Guo. Discussion: https://postgr.es/m/18277-089ead83b329a2fd@postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c3f52fd5d7160733e6b78fc8957e8990a3341bda Modified Files -------------- src/backend/nodes/nodeFuncs.c | 6 ++++++ 1 file changed, 6 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Handle WindowClause.runCondition in tree walker/mutator function @ 2024-01-10 18:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2024-01-10 18:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Handle WindowClause.runCondition in tree walker/mutator functions. Commit 9d9c02ccd, which added the notion of a "run condition" for window functions, neglected to teach nodeFuncs.c to process the new field. Remarkably, that doesn't seem to have had any ill effects before we invented Var.varnullingrels, but now it can cause visible failures in join-removal scenarios. I have no faith that there's not reachable problems in v15 too, so back-patch the code change to v15 where 9d9c02ccd came in. The test case seems irrelevant to v15, though. Per bug #18277 from Zuming Jiang. Diagnosis and patch by Richard Guo. Discussion: https://postgr.es/m/18277-089ead83b329a2fd@postgresql.org Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ee955321869e46289d11b0c77255c74d62caf3a5 Modified Files -------------- src/backend/nodes/nodeFuncs.c | 6 ++++++ src/test/regress/expected/window.out | 26 ++++++++++++++++++++++++++ src/test/regress/sql/window.sql | 9 +++++++++ 3 files changed, 41 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Handle WindowClause.runCondition in tree walker/mutator function @ 2024-01-10 18:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2024-01-10 18:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Handle WindowClause.runCondition in tree walker/mutator functions. Commit 9d9c02ccd, which added the notion of a "run condition" for window functions, neglected to teach nodeFuncs.c to process the new field. Remarkably, that doesn't seem to have had any ill effects before we invented Var.varnullingrels, but now it can cause visible failures in join-removal scenarios. I have no faith that there's not reachable problems in v15 too, so back-patch the code change to v15 where 9d9c02ccd came in. The test case seems irrelevant to v15, though. Per bug #18277 from Zuming Jiang. Diagnosis and patch by Richard Guo. Discussion: https://postgr.es/m/18277-089ead83b329a2fd@postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/d641b827af3966e349cbcc592bc51a4ab770c37b Modified Files -------------- src/backend/nodes/nodeFuncs.c | 6 ++++++ src/test/regress/expected/window.out | 26 ++++++++++++++++++++++++++ src/test/regress/sql/window.sql | 9 +++++++++ 3 files changed, 41 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-01-10 18:36 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-01-10 18:36 pgsql: Handle WindowClause.runCondition in tree walker/mutator function Tom Lane <tgl@sss.pgh.pa.us> 2024-01-10 18:36 pgsql: Handle WindowClause.runCondition in tree walker/mutator function Tom Lane <tgl@sss.pgh.pa.us> 2024-01-10 18:36 pgsql: Handle WindowClause.runCondition in tree walker/mutator function Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox