From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Handle WindowClause.runCondition in tree walker/mutator function
Date: Wed, 10 Jan 2024 18:36:54 +0000
Message-ID: <E1rNdRe-000nzn-SK@gemulon.postgresql.org> (raw)
Handle WindowClause.runCondition in tree walker/mutator functions.
Commit 9d9c02ccd, which added the notion of a "run condition" for
window functions, neglected to teach nodeFuncs.c to process the new
field. Remarkably, that doesn't seem to have had any ill effects
before we invented Var.varnullingrels, but now it can cause visible
failures in join-removal scenarios.
I have no faith that there's not reachable problems in v15 too,
so back-patch the code change to v15 where 9d9c02ccd came in.
The test case seems irrelevant to v15, though.
Per bug #18277 from Zuming Jiang. Diagnosis and patch by
Richard Guo.
Discussion: https://postgr.es/m/18277-089ead83b329a2fd@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d641b827af3966e349cbcc592bc51a4ab770c37b
Modified Files
--------------
src/backend/nodes/nodeFuncs.c | 6 ++++++
src/test/regress/expected/window.out | 26 ++++++++++++++++++++++++++
src/test/regress/sql/window.sql | 9 +++++++++
3 files changed, 41 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Handle WindowClause.runCondition in tree walker/mutator function
In-Reply-To: <E1rNdRe-000nzn-SK@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox