pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Allow noise semicolons ending psql \sf, \ef, \sv, \ev commands.
Date: Wed, 10 Jan 2024 19:20:15 +0000
Message-ID: <E1rNe7b-000oFn-QD@gemulon.postgresql.org> (raw)

Allow noise semicolons ending psql \sf, \ef, \sv, \ev commands.

Many psql backslash commands tolerate trailing semicolons, even
though that's not part of the official syntax.  These did not.
They tried to, by passing semicolon = true to psql_scan_slash_option,
but that function ignored this parameter in OT_WHOLE_LINE mode.
Teach it to do the right thing, and remove the now-duplicative
logic in exec_command_help.

Discussion: https://postgr.es/m/2012251.1704746912@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/390298f0806588ceb131dd47760208bd2cd6298f

Modified Files
--------------
src/bin/psql/command.c             | 17 +++++------------
src/bin/psql/psqlscanslash.l       | 21 +++++++++++++++++++--
src/test/regress/expected/psql.out |  2 +-
src/test/regress/sql/psql.sql      |  2 +-
4 files changed, 26 insertions(+), 16 deletions(-)



Message-ID: <E1rNe7b-000oFn-QD@gemulon.postgresql.org>
Permalink:  ../E1rNe7b-000oFn-QD@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rNe7b-000oFn-QD@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Allow noise semicolons ending psql \sf, \ef, \sv, \ev commands.
  In-Reply-To: <E1rNe7b-000oFn-QD@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox