From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rework how logirep launchers are stopped during pg_upgrade
Date: Thu, 11 Jan 2024 23:27:02 +0000
Message-ID: <E1rO4Ry-000ynn-Qd@gemulon.postgresql.org> (raw)
Rework how logirep launchers are stopped during pg_upgrade
This is a rework of 7021d3b17664, where we relied on forcing
max_logical_replication_workers to 0 in the postgres command. This
commit now prevents logical replication launchers to start using -b and
a backend-side check based on IsBinaryUpgrade, effective when upgrading
from 17 and newer versions.
This commit improves the comments explaining why this restriction is
necessary.
This discussion was on hold until we were sure how to add support for
subscribers in pg_upgrade, something now done thanks to 9a17be1e244a.
Reviewed-by: Álvaro Herrera, Amit Kapila, Tom Lane
Discussion: https://postgr.es/m/ZU2TeVkUg5qEi7Oy@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/08c3ad27eb5348d0cbffa843a3edb11534f9904a
Modified Files
--------------
src/backend/replication/logical/launcher.c | 9 ++++++++-
src/bin/pg_upgrade/server.c | 15 +++++----------
2 files changed, 13 insertions(+), 11 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework how logirep launchers are stopped during pg_upgrade
In-Reply-To: <E1rO4Ry-000ynn-Qd@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox