From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove the flaky check in event_trigger_login regression test
Date: Wed, 17 Jan 2024 21:23:36 +0000
Message-ID: <E1rQDNo-001u1T-Ti@gemulon.postgresql.org> (raw)
Remove the flaky check in event_trigger_login regression test
The query checks that pg_database.dathasloginevt is unset on connect when
there are no event triggers. However, unsetting this flag is implemented in
a non-blocking way, so a concurrent autovacuum connection breaks this check.
It doesn't seem we can do much with this, at least within a regression test.
So, remove it.
Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/44807d19-81a6-3884-3e0f-22dd99aac3ed%40gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4b885d01f9676f62d8b8156e45282c631181369f
Modified Files
--------------
src/test/regress/expected/event_trigger_login.out | 6 ------
src/test/regress/sql/event_trigger_login.sql | 1 -
2 files changed, 7 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove the flaky check in event_trigger_login regression test
In-Reply-To: <E1rQDNo-001u1T-Ti@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox