pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve notation of BuiltinTrancheNames
Date: Wed, 24 Jan 2024 14:04:38 +0000
Message-ID: <E1rSdrq-002tIW-EL@gemulon.postgresql.org> (raw)

Improve notation of BuiltinTrancheNames

Use C99 designated initializer syntax for array elements, instead of
writing the position in a comment.  This is less verbose and much more
readable.  Akin to cc150596341e.

One disadvantage is that the BuiltinTrancheNames array now has a hole of
51 NULLs -- previously, the array elements were shifted 51 elements
 downward to avoid this.  This can be fixed by merging the
IndividualLWLockNames array into BuiltinTrancheNames, which would occupy
those 51 pointers, but because it requires some arguably ugly Meson
hackery, it's left for later.

Discussion: https://postgr.es/m/202401231025.gbv4nnte5fmm@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/74a73063106583b1f49274a2cd1df42e35107361

Modified Files
--------------
src/backend/storage/lmgr/lwlock.c | 97 +++++++++++++--------------------------
1 file changed, 33 insertions(+), 64 deletions(-)



Message-ID: <E1rSdrq-002tIW-EL@gemulon.postgresql.org>
Permalink:  ../E1rSdrq-002tIW-EL@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rSdrq-002tIW-EL@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve notation of BuiltinTrancheNames
  In-Reply-To: <E1rSdrq-002tIW-EL@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox