From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Add support for parsing of large XML data (>= 10MB)"
Date: Fri, 26 Jan 2024 01:23:47 +0000
Message-ID: <E1rTAwd-0037xa-2s@gemulon.postgresql.org> (raw)
Revert "Add support for parsing of large XML data (>= 10MB)"
This reverts commit 2197d06224a1, following a discussion over a Coverity
report where issues like the "Billion laugh attack" could cause the
backend to waste CPU and memory even if a client applied checks on the
size of the data given in input, and libxml2 does not offer guarantees
that input limits are respected under XML_PARSE_HUGE.
Discussion: https://postgr.es/m/ZbHlgrPLtBZyr_QW@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f2743a7d70e7b2891277632121bb51e739743a47
Modified Files
--------------
contrib/xml2/xpath.c | 4 ++--
contrib/xml2/xslt_proc.c | 4 ++--
src/backend/utils/adt/xml.c | 38 +++++++++-----------------------------
3 files changed, 13 insertions(+), 33 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Revert "Add support for parsing of large XML data (>= 10MB)"
In-Reply-To: <E1rTAwd-0037xa-2s@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox