pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Temporary patch to help debug pg_walsummary test failures.
Date: Fri, 26 Jan 2024 18:37:17 +0000
Message-ID: <E1rTR4n-003EqY-R9@gemulon.postgresql.org> (raw)

Temporary patch to help debug pg_walsummary test failures.

The tests in 002_blocks.pl are failing in the buildfarm from time to
time, but we don't know how to reproduce the failure elsewhere. The
most obvious explanation seems to be the unexpected disappearance of a
WAL summary file, so bump up the logging level in
RemoveWalSummaryIfOlderThan to try to help us spot such problems, and
print the cutoff time in addition to the removed filename. Also
adjust 002_blocks.pl to dump out a directory listing of the relevant
directory at various points.

This patch should be reverted once we sort out what's happening here.

Patch by me, reviewed by Nathan Bossart, who also reported the issue.

Discussion: http://postgr.es/m/20240124170846.GA2643050@nathanxps13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5ddf9973477729cf161b4ad0a1efd52f4fea9c88

Modified Files
--------------
src/backend/backup/walsummary.c       |  7 +++++++
src/bin/pg_walsummary/t/002_blocks.pl | 14 ++++++++++++++
2 files changed, 21 insertions(+)



view thread (4+ messages)  latest in thread

Message-ID: <E1rTR4n-003EqY-R9@gemulon.postgresql.org>
Permalink:  ../E1rTR4n-003EqY-R9@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rTR4n-003EqY-R9@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Temporary patch to help debug pg_walsummary test failures.
  In-Reply-To: <E1rTR4n-003EqY-R9@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox