From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Detect Julian-date overflow in timestamp[tz]_pl_interval.
Date: Fri, 26 Jan 2024 18:40:03 +0000
Message-ID: <E1rTR7T-003Esv-BP@gemulon.postgresql.org> (raw)
Detect Julian-date overflow in timestamp[tz]_pl_interval.
We perform addition of the days field of an interval via
arithmetic on the Julian-date representation of the timestamp's date.
This step is subject to int32 overflow, and we also should not let
the Julian date become very negative, for fear of weird results from
j2date. (In the timestamptz case, allow a Julian date of -1 to pass,
since it might convert back to zero after timezone rotation.)
The additions of the months and microseconds fields could also
overflow, of course. However, I believe we need no additional
checks there; the existing range checks should catch such cases.
The difficulty here is that j2date's magic modular arithmetic could
produce something that looks like it's in-range.
Per bug #18313 from Christian Maurer. This has been wrong for
a long time, so back-patch to all supported branches.
Discussion: https://postgr.es/m/18313-64d2c8952d81e84b@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/25cd2d64021ae081cbcef1592e0ee04ddda2e975
Modified Files
--------------
src/backend/utils/adt/timestamp.c | 27 +++++++++++++++++++++++----
src/test/regress/expected/horology.out | 4 ++++
src/test/regress/sql/horology.sql | 2 ++
3 files changed, 29 insertions(+), 4 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Detect Julian-date overflow in timestamp[tz]_pl_interval.
In-Reply-To: <E1rTR7T-003Esv-BP@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox