From: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove ReorderBufferTupleBuf structure.
Date: Mon, 29 Jan 2024 01:39:46 +0000
Message-ID: <E1rUGck-003btN-4C@gemulon.postgresql.org> (raw)
Remove ReorderBufferTupleBuf structure.
Since commit a4ccc1cef, the 'node' and 'alloc_tuple_size' fields of
the ReorderBufferTupleBuf structure are no longer used. This leaves
only the 'tuple' field in the structure. Since keeping a single-field
structure makes little sense, the ReorderBufferTupleBuf is removed
entirely. The code is refactored accordingly.
No back-patching since these are ABI changes in an exposed structure
and functions, and there would be some risk of breaking extensions.
Author: Aleksander Alekseev
Reviewed-by: Amit Kapila, Masahiko Sawada, Reid Thompson
Discussion: https://postgr.es/m/CAD21AoCvnuxiXXfRecp7g9+CeC35POQfhuQeJFr7_9u_Q5jc_Q@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/08e6344fd6423210b339e92c069bb979ba4e7cd6
Modified Files
--------------
contrib/test_decoding/test_decoding.c | 8 +--
src/backend/replication/logical/decode.c | 26 ++++----
src/backend/replication/logical/reorderbuffer.c | 89 ++++++++++++-------------
src/backend/replication/pgoutput/pgoutput.c | 4 +-
src/include/replication/reorderbuffer.h | 31 ++-------
src/tools/pgindent/typedefs.list | 1 -
6 files changed, 68 insertions(+), 91 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove ReorderBufferTupleBuf structure.
In-Reply-To: <E1rUGck-003btN-4C@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox