pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Simplify partial path generation in GROUP BY/ORDER BY
Date: Tue, 30 Jan 2024 21:11:48 +0000
Message-ID: <E1rUvOW-003tm5-TW@gemulon.postgresql.org> (raw)

Simplify partial path generation in GROUP BY/ORDER BY

Here we consolidate the generation of partial sort and partial incremental
sort paths in a similar way to what was done in 4a29eabd1.  Since the cost
penalty for incremental sort was removed by that commit, there's no
point in creating a sort path on the cheapest partial path if an
incremental sort could be done instead.

This has the added benefit of reducing the amount of code required to
build these paths.

Author: Richard Guo
Reviewed-by: Etsuro Fujita, Shubham Khanna, David Rowley
Discussion: https://postgr.es/m/CAMbWs49PaKxBZU9cN7k3DKB7id+YfGfOfS9H_Fo5tkqPMt=fDg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8ee9c250875157d42f7ed53508e239d23ce514fb

Modified Files
--------------
src/backend/optimizer/plan/planner.c          | 201 ++++++++++----------------
src/test/regress/expected/select_parallel.out |  53 +++++++
src/test/regress/sql/select_parallel.sql      |  26 ++++
3 files changed, 156 insertions(+), 124 deletions(-)



Message-ID: <E1rUvOW-003tm5-TW@gemulon.postgresql.org>
Permalink:  ../E1rUvOW-003tm5-TW@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rUvOW-003tm5-TW@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Simplify partial path generation in GROUP BY/ORDER BY
  In-Reply-To: <E1rUvOW-003tm5-TW@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox