pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix assertion if index is dropped during REFRESH CONCURRENTLY
Date: Mon, 05 Feb 2024 09:28:32 +0000
Message-ID: <E1rWvHE-004kuz-53@gemulon.postgresql.org> (raw)

Fix assertion if index is dropped during REFRESH CONCURRENTLY

When assertions are disabled, the built SQL statement is invalid and
you get a "syntax error". So this isn't a serious problem, but let's
avoid the assertion failure.

Backpatch to all supported versions.

Reviewed-by: Noah Misch

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b73d216489e1ee480b19d6ad31b784ea33c352f3

Modified Files
--------------
src/backend/commands/matview.c        |  7 +++++--
src/test/regress/expected/matview.out | 16 ++++++++++++++++
src/test/regress/sql/matview.sql      | 17 +++++++++++++++++
3 files changed, 38 insertions(+), 2 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1rWvHE-004kuz-53@gemulon.postgresql.org>
Permalink:  ../E1rWvHE-004kuz-53@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rWvHE-004kuz-53@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix assertion if index is dropped during REFRESH CONCURRENTLY
  In-Reply-To: <E1rWvHE-004kuz-53@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox