public inbox for [email protected]
help / color / mirror / Atom feedFrom: Daniel Gustafsson <[email protected]>
To: [email protected]
Subject: pgsql: Skip .DS_Store files in server side utils
Date: Tue, 13 Feb 2024 12:58:06 +0000
Message-ID: <[email protected]> (raw)
Skip .DS_Store files in server side utils
The macOS Finder application creates .DS_Store files in directories
when opened, which creates problems for serverside utilities which
expect all files to be PostgreSQL specific files. Skip these files
when encountered in pg_checksums, pg_rewind and pg_basebackup.
This was extracted from a larger patchset for skipping hidden files
and system files, where the concencus was to just skip these. Since
this is equally likely to happen in every version, backpatch to all
supported versions.
Reported-by: Mark Guertin <[email protected]>
Reviewed-by: Michael Paquier <[email protected]>
Reviewed-by: Tobias Bussmann <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: v12
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d3fdfdcd1c7f1b714a9a85b893d2c5afc60bea91
Modified Files
--------------
doc/src/sgml/protocol.sgml | 2 +-
doc/src/sgml/ref/pg_basebackup.sgml | 3 ++-
doc/src/sgml/ref/pg_rewind.sgml | 5 +++--
src/backend/replication/basebackup.c | 4 ++++
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 16 ++++++++++++++++
src/bin/pg_checksums/pg_checksums.c | 4 ++++
src/bin/pg_checksums/t/002_actions.pl | 7 +++++++
src/bin/pg_rewind/filemap.c | 4 ++++
src/bin/pg_rewind/t/003_extrafiles.pl | 5 +++++
9 files changed, 46 insertions(+), 4 deletions(-)
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgsql: Skip .DS_Store files in server side utils
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox