public inbox for [email protected]
help / color / mirror / Atom feedpgsql: Skip .DS_Store files in server side utils
7+ messages / 2 participants
[nested] [flat]
* pgsql: Skip .DS_Store files in server side utils
@ 2024-02-13 12:54 Daniel Gustafsson <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Gustafsson @ 2024-02-13 12:54 UTC (permalink / raw)
To: [email protected]
Skip .DS_Store files in server side utils
The macOS Finder application creates .DS_Store files in directories
when opened, which creates problems for serverside utilities which
expect all files to be PostgreSQL specific files. Skip these files
when encountered in pg_checksums, pg_rewind and pg_basebackup.
This was extracted from a larger patchset for skipping hidden files
and system files, where the concencus was to just skip these. Since
this is equally likely to happen in every version, backpatch to all
supported versions.
Reported-by: Mark Guertin <[email protected]>
Reviewed-by: Michael Paquier <[email protected]>
Reviewed-by: Tobias Bussmann <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: v12
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c1fc502f595bc843a603bddd267b249272de485f
Modified Files
--------------
doc/src/sgml/protocol.sgml | 2 +-
doc/src/sgml/ref/pg_basebackup.sgml | 3 ++-
doc/src/sgml/ref/pg_rewind.sgml | 5 +++--
src/backend/backup/basebackup.c | 4 ++++
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 17 +++++++++++++++++
src/bin/pg_checksums/pg_checksums.c | 4 ++++
src/bin/pg_checksums/t/002_actions.pl | 7 +++++++
src/bin/pg_rewind/filemap.c | 4 ++++
src/bin/pg_rewind/t/003_extrafiles.pl | 5 +++++
9 files changed, 47 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Skip .DS_Store files in server side utils
@ 2024-02-13 12:57 Daniel Gustafsson <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Gustafsson @ 2024-02-13 12:57 UTC (permalink / raw)
To: [email protected]
Skip .DS_Store files in server side utils
The macOS Finder application creates .DS_Store files in directories
when opened, which creates problems for serverside utilities which
expect all files to be PostgreSQL specific files. Skip these files
when encountered in pg_checksums, pg_rewind and pg_basebackup.
This was extracted from a larger patchset for skipping hidden files
and system files, where the concencus was to just skip these. Since
this is equally likely to happen in every version, backpatch to all
supported versions.
Reported-by: Mark Guertin <[email protected]>
Reviewed-by: Michael Paquier <[email protected]>
Reviewed-by: Tobias Bussmann <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: v12
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/103235888d9e74755ec4c7a72d640d4c7fabc596
Modified Files
--------------
doc/src/sgml/protocol.sgml | 2 +-
doc/src/sgml/ref/pg_basebackup.sgml | 3 ++-
doc/src/sgml/ref/pg_rewind.sgml | 5 +++--
src/backend/backup/basebackup.c | 4 ++++
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 17 +++++++++++++++++
src/bin/pg_checksums/pg_checksums.c | 4 ++++
src/bin/pg_checksums/t/002_actions.pl | 7 +++++++
src/bin/pg_rewind/filemap.c | 4 ++++
src/bin/pg_rewind/t/003_extrafiles.pl | 5 +++++
9 files changed, 47 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Skip .DS_Store files in server side utils
@ 2024-02-13 12:57 Daniel Gustafsson <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Gustafsson @ 2024-02-13 12:57 UTC (permalink / raw)
To: [email protected]
Skip .DS_Store files in server side utils
The macOS Finder application creates .DS_Store files in directories
when opened, which creates problems for serverside utilities which
expect all files to be PostgreSQL specific files. Skip these files
when encountered in pg_checksums, pg_rewind and pg_basebackup.
This was extracted from a larger patchset for skipping hidden files
and system files, where the concencus was to just skip these. Since
this is equally likely to happen in every version, backpatch to all
supported versions.
Reported-by: Mark Guertin <[email protected]>
Reviewed-by: Michael Paquier <[email protected]>
Reviewed-by: Tobias Bussmann <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: v12
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/29f00523808ac1d646cf51f9fe199e61ce5631e7
Modified Files
--------------
doc/src/sgml/protocol.sgml | 2 +-
doc/src/sgml/ref/pg_basebackup.sgml | 3 ++-
doc/src/sgml/ref/pg_rewind.sgml | 5 +++--
src/backend/backup/basebackup.c | 4 ++++
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 17 +++++++++++++++++
src/bin/pg_checksums/pg_checksums.c | 4 ++++
src/bin/pg_checksums/t/002_actions.pl | 7 +++++++
src/bin/pg_rewind/filemap.c | 4 ++++
src/bin/pg_rewind/t/003_extrafiles.pl | 5 +++++
9 files changed, 47 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Skip .DS_Store files in server side utils
@ 2024-02-13 12:57 Daniel Gustafsson <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Gustafsson @ 2024-02-13 12:57 UTC (permalink / raw)
To: [email protected]
Skip .DS_Store files in server side utils
The macOS Finder application creates .DS_Store files in directories
when opened, which creates problems for serverside utilities which
expect all files to be PostgreSQL specific files. Skip these files
when encountered in pg_checksums, pg_rewind and pg_basebackup.
This was extracted from a larger patchset for skipping hidden files
and system files, where the concencus was to just skip these. Since
this is equally likely to happen in every version, backpatch to all
supported versions.
Reported-by: Mark Guertin <[email protected]>
Reviewed-by: Michael Paquier <[email protected]>
Reviewed-by: Tobias Bussmann <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: v12
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/aeee173d229232f94acc61e7bfe81d40f56e478e
Modified Files
--------------
doc/src/sgml/protocol.sgml | 2 +-
doc/src/sgml/ref/pg_basebackup.sgml | 3 ++-
doc/src/sgml/ref/pg_rewind.sgml | 5 +++--
src/backend/replication/basebackup.c | 4 ++++
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 16 ++++++++++++++++
src/bin/pg_checksums/pg_checksums.c | 4 ++++
src/bin/pg_checksums/t/002_actions.pl | 7 +++++++
src/bin/pg_rewind/filemap.c | 4 ++++
src/bin/pg_rewind/t/003_extrafiles.pl | 5 +++++
9 files changed, 46 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Skip .DS_Store files in server side utils
@ 2024-02-13 12:58 Daniel Gustafsson <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Gustafsson @ 2024-02-13 12:58 UTC (permalink / raw)
To: [email protected]
Skip .DS_Store files in server side utils
The macOS Finder application creates .DS_Store files in directories
when opened, which creates problems for serverside utilities which
expect all files to be PostgreSQL specific files. Skip these files
when encountered in pg_checksums, pg_rewind and pg_basebackup.
This was extracted from a larger patchset for skipping hidden files
and system files, where the concencus was to just skip these. Since
this is equally likely to happen in every version, backpatch to all
supported versions.
Reported-by: Mark Guertin <[email protected]>
Reviewed-by: Michael Paquier <[email protected]>
Reviewed-by: Tobias Bussmann <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: v12
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d3fdfdcd1c7f1b714a9a85b893d2c5afc60bea91
Modified Files
--------------
doc/src/sgml/protocol.sgml | 2 +-
doc/src/sgml/ref/pg_basebackup.sgml | 3 ++-
doc/src/sgml/ref/pg_rewind.sgml | 5 +++--
src/backend/replication/basebackup.c | 4 ++++
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 16 ++++++++++++++++
src/bin/pg_checksums/pg_checksums.c | 4 ++++
src/bin/pg_checksums/t/002_actions.pl | 7 +++++++
src/bin/pg_rewind/filemap.c | 4 ++++
src/bin/pg_rewind/t/003_extrafiles.pl | 5 +++++
9 files changed, 46 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Skip .DS_Store files in server side utils
@ 2024-02-13 12:58 Daniel Gustafsson <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Gustafsson @ 2024-02-13 12:58 UTC (permalink / raw)
To: [email protected]
Skip .DS_Store files in server side utils
The macOS Finder application creates .DS_Store files in directories
when opened, which creates problems for serverside utilities which
expect all files to be PostgreSQL specific files. Skip these files
when encountered in pg_checksums, pg_rewind and pg_basebackup.
This was extracted from a larger patchset for skipping hidden files
and system files, where the concencus was to just skip these. Since
this is equally likely to happen in every version, backpatch to all
supported versions.
Reported-by: Mark Guertin <[email protected]>
Reviewed-by: Michael Paquier <[email protected]>
Reviewed-by: Tobias Bussmann <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: v12
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/76bb6dd2e56c14e947196e638f86982424c51254
Modified Files
--------------
doc/src/sgml/protocol.sgml | 2 +-
doc/src/sgml/ref/pg_basebackup.sgml | 3 ++-
doc/src/sgml/ref/pg_rewind.sgml | 5 +++--
src/backend/replication/basebackup.c | 4 ++++
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 16 ++++++++++++++++
src/bin/pg_checksums/pg_checksums.c | 4 ++++
src/bin/pg_checksums/t/002_actions.pl | 7 +++++++
src/bin/pg_rewind/filemap.c | 4 ++++
src/bin/pg_rewind/t/003_extrafiles.pl | 5 +++++
9 files changed, 46 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgsql: Skip .DS_Store files in server side utils
@ 2024-02-13 13:20 Daniel Gustafsson <[email protected]>
parent: Daniel Gustafsson <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Gustafsson @ 2024-02-13 13:20 UTC (permalink / raw)
To: Daniel Gustafsson <[email protected]>; +Cc: [email protected]
> On 13 Feb 2024, at 13:54, Daniel Gustafsson <[email protected]> wrote:
>
> Skip .DS_Store files in server side utils
> Backpatch-through: v12
Some BF animals for 14-12 failed, so have reverted to allow time for figuring
out a proper fix. Sorry for the noice.
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-02-13 13:20 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-02-13 12:54 pgsql: Skip .DS_Store files in server side utils Daniel Gustafsson <[email protected]>
2024-02-13 13:20 ` Daniel Gustafsson <[email protected]>
2024-02-13 12:57 pgsql: Skip .DS_Store files in server side utils Daniel Gustafsson <[email protected]>
2024-02-13 12:57 pgsql: Skip .DS_Store files in server side utils Daniel Gustafsson <[email protected]>
2024-02-13 12:57 pgsql: Skip .DS_Store files in server side utils Daniel Gustafsson <[email protected]>
2024-02-13 12:58 pgsql: Skip .DS_Store files in server side utils Daniel Gustafsson <[email protected]>
2024-02-13 12:58 pgsql: Skip .DS_Store files in server side utils Daniel Gustafsson <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox