From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rework locking code in GetMultiXactIdMembers
Date: Mon, 04 Mar 2024 16:51:43 +0000
Message-ID: <E1rhBXT-0023rL-5D@gemulon.postgresql.org> (raw)
Rework locking code in GetMultiXactIdMembers
After commit 53c2a97a9266, the code flow around the "retry" goto label
in GetMultiXactIdMembers was confused about what was possible: we never
return there with a held lock, so there's no point in testing for one.
This realization lets us simplify the code a bit. While at it, make the
scope of a couple of local variables in the same function a bit tighter.
Per Coverity.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a0b808baef39e9f9465b7f63f2d735f35852aa21
Modified Files
--------------
src/backend/access/transam/multixact.c | 53 ++++++++++++++--------------------
1 file changed, 22 insertions(+), 31 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework locking code in GetMultiXactIdMembers
In-Reply-To: <E1rhBXT-0023rL-5D@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox