pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rename pg_constraint.conwithoutoverlaps to conperiod
Date: Tue, 05 Mar 2024 10:28:50 +0000
Message-ID: <E1rhS2U-002C8Z-HH@gemulon.postgresql.org> (raw)

Rename pg_constraint.conwithoutoverlaps to conperiod

pg_constraint.conwithoutoverlaps was recently added to support primary
keys and unique constraints with the WITHOUT OVERLAPS clause.  An
upcoming patch provides the foreign-key side of this functionality,
but the syntax there is different and uses the keyword PERIOD.  It
would make sense to use the same pg_constraint field for both of
these, but then we should pick a more general name that conveys "this
constraint has a temporal/period-related feature".  conperiod works
for that and is nicely compact.  Changing this now avoids possibly
having to introduce versioning into clients.  Note there are still
some "without overlaps" variables left, which deal specifically with
the parsing of the primary key/unique constraint feature.

Author: Paul A. Jungwirth <pj@illuminatedcomputing.com>
Discussion: https://www.postgresql.org/message-id/flat/CA+renyUApHgSZF9-nd-a0+OPGharLQLO=mDHcY4_qQ0+noCUVg@mail....

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/030e10ff1a365796bd4bcbbc5b6a8552f7efc765

Modified Files
--------------
doc/src/sgml/catalogs.sgml          |  2 +-
src/backend/catalog/heap.c          |  4 ++--
src/backend/catalog/pg_constraint.c |  4 ++--
src/backend/commands/tablecmds.c    |  6 +++---
src/backend/commands/trigger.c      |  2 +-
src/backend/commands/typecmds.c     |  2 +-
src/backend/utils/adt/ruleutils.c   |  2 +-
src/backend/utils/cache/relcache.c  |  6 +++---
src/bin/pg_dump/pg_dump.c           | 12 ++++++------
src/bin/pg_dump/pg_dump.h           |  3 +--
src/bin/psql/describe.c             |  4 ++--
src/include/catalog/catversion.h    |  2 +-
src/include/catalog/pg_constraint.h |  4 ++--
13 files changed, 26 insertions(+), 27 deletions(-)



view thread (2+ messages)

Message-ID: <E1rhS2U-002C8Z-HH@gemulon.postgresql.org>
Permalink:  ../E1rhS2U-002C8Z-HH@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rhS2U-002C8Z-HH@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Rename pg_constraint.conwithoutoverlaps to conperiod
  In-Reply-To: <E1rhS2U-002C8Z-HH@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox