pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve field order in RangeTblEntry
Date: Tue, 05 Mar 2024 12:43:11 +0000
Message-ID: <E1rhU8V-002D2Q-8s@gemulon.postgresql.org> (raw)

Improve field order in RangeTblEntry

When perminfoindex was added, it was just added at the end of the
block.  It would make sense to keep it closer to more related fields.
In passing, also add an inline comment, like the other fields have.
(Other field reorderings and documentation improvements in
RangeTblEntry are being discussed, but it's better not to mix them
together.)

Discussion: https://www.postgresql.org/message-id/flat/6c1fbccc-85c8-40d3-b08b-4f47f2093711%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e03349144b00b775523f3e0ea8ef56ec2fb44b11

Modified Files
--------------
src/backend/nodes/outfuncs.c     | 2 +-
src/backend/nodes/readfuncs.c    | 2 +-
src/include/catalog/catversion.h | 2 +-
src/include/nodes/parsenodes.h   | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)



view thread (3+ messages)

Message-ID: <E1rhU8V-002D2Q-8s@gemulon.postgresql.org>
Permalink:  ../E1rhU8V-002D2Q-8s@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rhU8V-002D2Q-8s@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve field order in RangeTblEntry
  In-Reply-To: <E1rhU8V-002D2Q-8s@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox