pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add --copy-file-range option to pg_upgrade.
Date: Tue, 05 Mar 2024 23:04:01 +0000
Message-ID: <E1rhdpJ-002HuY-7A@gemulon.postgresql.org> (raw)

Add --copy-file-range option to pg_upgrade.

The copy_file_range() system call is available on at least Linux and
FreeBSD, and asks the kernel to use efficient ways to copy ranges of a
file.  Options available to the kernel include sharing block ranges
(similar to --clone mode), and pushing down block copies to the storage
layer.

For automated testing, see PG_TEST_PG_UPGRADE_MODE.  (Perhaps in a later
commit we could consider setting this mode for one of the CI targets.)

Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/CA%2BhUKGKe7Hb0-UNih8VD5UNZy5-ojxFb3Pr3xSBBL8qj2M2%3DdQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d93627bcbe5001750e7611f0e637200e2d81dcff

Modified Files
--------------
configure                          |  2 +-
configure.ac                       |  1 +
doc/src/sgml/ref/pgupgrade.sgml    | 13 +++++++
meson.build                        |  1 +
src/bin/pg_upgrade/TESTING         |  4 +-
src/bin/pg_upgrade/check.c         |  3 ++
src/bin/pg_upgrade/file.c          | 78 ++++++++++++++++++++++++++++++++++++++
src/bin/pg_upgrade/option.c        |  7 +++-
src/bin/pg_upgrade/pg_upgrade.h    |  4 ++
src/bin/pg_upgrade/relfilenumber.c |  8 ++++
src/include/pg_config.h.in         |  3 ++
11 files changed, 120 insertions(+), 4 deletions(-)



view thread (2+ messages)

Message-ID: <E1rhdpJ-002HuY-7A@gemulon.postgresql.org>
Permalink:  ../E1rhdpJ-002HuY-7A@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rhdpJ-002HuY-7A@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add --copy-file-range option to pg_upgrade.
  In-Reply-To: <E1rhdpJ-002HuY-7A@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox