From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix description and grouping of RangeTblEntry.inh
Date: Thu, 07 Mar 2024 11:22:22 +0000
Message-ID: <E1riBpO-002XYC-HN@gemulon.postgresql.org> (raw)
Fix description and grouping of RangeTblEntry.inh
The inh field of RangeTblEntry was doubly confusingly documented.
Some parts of the code insisted that it was only valid for
RTE_RELATION entries, other parts said the field was valid for all
entries. Neither was quite correct. More correctly, the field is
valid for RTE_RELATION entries but is also used in the planner for
RTE_SUBQUERY entries. So it makes more sense to group it with other
fields that are primarily for RTE_RELATION but borrowed by
RTE_SUBQUERY. (The exact position was chosen so that it is next to
relkind for better struct packing, and next to relid, since relid and
inh are sort of the input fields and the others are filled in later.)
Also add documentation for the planner's use at the struct definition.
Discussion: https://www.postgresql.org/message-id/6c1fbccc-85c8-40d3-b08b-4f47f2093711@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6d470211e54f7a617783b99b27c9d8056a890a57
Modified Files
--------------
src/backend/nodes/outfuncs.c | 3 ++-
src/backend/nodes/queryjumblefuncs.c | 2 +-
src/backend/nodes/readfuncs.c | 3 ++-
src/backend/parser/parse_relation.c | 11 ++---------
src/include/catalog/catversion.h | 2 +-
src/include/nodes/parsenodes.h | 13 ++++++++-----
6 files changed, 16 insertions(+), 18 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix description and grouping of RangeTblEntry.inh
In-Reply-To: <E1riBpO-002XYC-HN@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox