From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Admit deferrable PKs into rd_pkindex, but flag them as such
Date: Fri, 08 Mar 2024 15:33:24 +0000
Message-ID: <E1ricDs-002jdc-8L@gemulon.postgresql.org> (raw)
Admit deferrable PKs into rd_pkindex, but flag them as such
... and in particular don't return them as replica identity.
The motivation for this change is letting the primary keys be seen by
code that derives NOT NULL constraints from them, when creating
inheritance children; before this change, if you had a deferrable PK,
pg_dump would not recreate the attnotnull marking properly, because the
column would not be considered as having anything to back said marking
after dropping the throwaway NOT NULL constraint.
The reason we don't want these PKs as replica identities is that
replication can corrupt data, if the uniqueness constraint is
transiently broken.
Reported-by: Amul Sul <sulamul@gmail.com>
Reviewed-by: Dean Rasheed <dean.a.rasheed@gmail.com>
Discussion: https://postgr.es/m/CAAJ_b94QonkgsbDXofakHDnORQNgafd1y3Oa5QXfpQNJyXyQ7A@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/270af6f0df764d326e1a7355f4ce10dc73b05dac
Modified Files
--------------
src/backend/replication/logical/relation.c | 6 +-
src/backend/utils/cache/relcache.c | 27 ++++++--
src/include/utils/rel.h | 3 +-
src/test/regress/expected/constraints.out | 92 ++++++++++++++++++++++++++
src/test/regress/expected/publication.out | 10 +++
src/test/regress/expected/replica_identity.out | 5 ++
src/test/regress/sql/constraints.sql | 25 +++++++
src/test/regress/sql/publication.sql | 9 +++
src/test/regress/sql/replica_identity.sql | 4 ++
9 files changed, 170 insertions(+), 11 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Admit deferrable PKs into rd_pkindex, but flag them as such
In-Reply-To: <E1ricDs-002jdc-8L@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox