pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve wrong-tuple-type error reports in contrib/tablefunc.
Date: Sat, 09 Mar 2024 20:48:26 +0000
Message-ID: <E1rj3cI-002xoB-7Q@gemulon.postgresql.org> (raw)

Improve wrong-tuple-type error reports in contrib/tablefunc.

These messages were fairly confusing, and didn't match the
column names used in the SGML docs.  Try to improve that.
Also use error codes more specific than ERRCODE_SYNTAX_ERROR.

Patch by me, reviewed by Joe Conway

Discussion: https://postgr.es/m/18937.1709676295@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/76904eda25500dd4c6969f3a2a7c0f00146fd763

Modified Files
--------------
contrib/tablefunc/expected/tablefunc.out |  85 ++++++++++++++--
contrib/tablefunc/sql/tablefunc.sql      |  42 ++++++++
contrib/tablefunc/tablefunc.c            | 169 ++++++++++++++-----------------
3 files changed, 195 insertions(+), 101 deletions(-)



view thread (3+ messages)

Message-ID: <E1rj3cI-002xoB-7Q@gemulon.postgresql.org>
Permalink:  ../E1rj3cI-002xoB-7Q@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rj3cI-002xoB-7Q@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve wrong-tuple-type error reports in contrib/tablefunc.
  In-Reply-To: <E1rj3cI-002xoB-7Q@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox