From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Simplify and merge unwanted-module drop logic in AdjustUpgrade.p
Date: Sat, 09 Mar 2024 21:20:51 +0000
Message-ID: <E1rj47e-002y4r-VC@gemulon.postgresql.org> (raw)
Simplify and merge unwanted-module drop logic in AdjustUpgrade.pm.
In be7800674 and followups, we failed to notice that there was
already a better way to do it: instead of using DROP DATABASE
IF EXISTS, we can check the list of existing DBs. Also, there
seems no reason not to merge this into the pre-existing code
for getting rid of unwanted module databases.
Discussion: https://postgr.es/m/1066872.1710006597@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/519443162dce52a3b10372338401d63084f720b8
Modified Files
--------------
src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Simplify and merge unwanted-module drop logic in AdjustUpgrade.p
In-Reply-To: <E1rj47e-002y4r-VC@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox