pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Joe Conway <mail@joeconway.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make contrib/tablefunc crosstab() also check typmod
Date: Sat, 09 Mar 2024 22:34:02 +0000
Message-ID: <E1rj5GT-002yzP-SB@gemulon.postgresql.org> (raw)

Make contrib/tablefunc crosstab() also check typmod

contrib/tablefunc connectby() checks both type OID and typmod for
its output columns while crosstab() only checks type OID. Fix that
by makeing the crosstab() check look more like the connectby() check.

Reported-by: Tom Lane
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/flat/18937.1709676295%40sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/81d13a8dc066e571dca032da0a5fc1d81214d2bb

Modified Files
--------------
contrib/tablefunc/tablefunc.c | 32 +++++++++++++++++++-------------
1 file changed, 19 insertions(+), 13 deletions(-)



view thread (2+ messages)

Message-ID: <E1rj5GT-002yzP-SB@gemulon.postgresql.org>
Permalink:  ../E1rj5GT-002yzP-SB@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rj5GT-002yzP-SB@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: mail@joeconway.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Make contrib/tablefunc crosstab() also check typmod
  In-Reply-To: <E1rj5GT-002yzP-SB@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox