pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove redundant fetch of the recent flush pointer in WalSndWait
Date: Tue, 12 Mar 2024 05:07:53 +0000
Message-ID: <E1rjuMi-003Mxb-MH@gemulon.postgresql.org> (raw)

Remove redundant fetch of the recent flush pointer in WalSndWaitForWal.

In WalSndWaitForWal(), we fetch a recent flush pointer both outside the
loop and inside the loop. But we start using RecentFlushPtr only after we
fetch it inside the loop. So we can remove one outside the loop.

Author: Shveta Malik
Reviewed-by: Bertrand Drouvot, Matthias van de Meent, Amit Kapila
Discussion: https://postgr.es/m/CAJpy0uBSCQz1yMD-WiEthzEe23dti2-Kr_pitVb7vAPFbFKm=A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/397cd0b3c7d18c21daea175a8280afea723f4eac

Modified Files
--------------
src/backend/replication/walsender.c | 6 ------
1 file changed, 6 deletions(-)



view thread (2+ messages)

Message-ID: <E1rjuMi-003Mxb-MH@gemulon.postgresql.org>
Permalink:  ../E1rjuMi-003Mxb-MH@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rjuMi-003Mxb-MH@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove redundant fetch of the recent flush pointer in WalSndWait
  In-Reply-To: <E1rjuMi-003Mxb-MH@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox