From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add tests for more row patterns with COPY FROM .. (ON_ERROR igno
Date: Wed, 13 Mar 2024 05:20:50 +0000
Message-ID: <E1rkH2o-003XW2-8M@gemulon.postgresql.org> (raw)
Add tests for more row patterns with COPY FROM .. (ON_ERROR ignore)
While digging into the code of this feature, I got confused by the fact
that a line is skipped when a value cannot be converted to its expected
attribute even if the line has fewer attributes than the target
relation. The tests had a check for the case of an empty line, this
commit a couple more patterns where a line is incomplete, but skipped
because of a conversion error.
Reviewed-by: Bharath Rupireddy
Discussion: https://postgr.es/m/Ze_7kZqexdt0BiyC@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a189ed49d6292979be1478292246be61c4563043
Modified Files
--------------
src/test/regress/expected/copy2.out | 5 +++--
src/test/regress/sql/copy2.sql | 3 +++
2 files changed, 6 insertions(+), 2 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add tests for more row patterns with COPY FROM .. (ON_ERROR igno
In-Reply-To: <E1rkH2o-003XW2-8M@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox