pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Add basic TAP tests for the low-level backup method"
Date: Thu, 14 Mar 2024 04:27:13 +0000
Message-ID: <E1rkcgT-003hpd-EY@gemulon.postgresql.org> (raw)

Revert "Add basic TAP tests for the low-level backup method"

This reverts commit 99b4a63bef94.  The test is proving to be unstable,
so revert it for now.

One of the failures seen involves the cluster started without the
backup_label, where the archives of the primary are overwritten, causing
recovery failures on Windows.  This is simple to fix, but there is
another issue that's creeping behind in the form of an "invalid data in
file" ERROR when parsing the backup_label for the second recovery case,
as an effect of the backup_label data written after retrieving its
contents from pg_backup_stop().
_
Per buildfarm member sidewinder.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6cb1b632b354518a595f1b23bfbac28a798f7f1c

Modified Files
--------------
src/test/recovery/t/042_low_level_backup.pl | 120 ----------------------------
1 file changed, 120 deletions(-)



Message-ID: <E1rkcgT-003hpd-EY@gemulon.postgresql.org>
Permalink:  ../E1rkcgT-003hpd-EY@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rkcgT-003hpd-EY@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Revert "Add basic TAP tests for the low-level backup method"
  In-Reply-To: <E1rkcgT-003hpd-EY@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox