From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix false reports in pg_visibility
Date: Thu, 14 Mar 2024 11:25:42 +0000
Message-ID: <E1rkjDR-003kjA-SN@gemulon.postgresql.org> (raw)
Fix false reports in pg_visibility
Currently, pg_visibility computes its xid horizon using the
GetOldestNonRemovableTransactionId(). The problem is that this horizon can
sometimes go backward. That can lead to reporting false errors.
In order to fix that, this commit implements a new function
GetStrictOldestNonRemovableTransactionId(). This function computes the xid
horizon, which would be guaranteed to be newer or equal to any xid horizon
computed before.
We have to do the following to achieve this.
1. Ignore processes xmin's, because they consider connection to other databases
that were ignored before.
2. Ignore KnownAssignedXids, because they are not database-aware. At the same
time, the primary could compute its horizons database-aware.
3. Ignore walsender xmin, because it could go backward if some replication
connections don't use replication slots.
As a result, we're using only currently running xids to compute the horizon.
Surely these would significantly sacrifice accuracy. But we have to do so to
avoid reporting false errors.
Inspired by earlier patch by Daniel Shelepanov and the following discussion
with Robert Haas and Tom Lane.
Discussion: https://postgr.es/m/1649062270.289865713%40f403.i.mail.ru
Reviewed-by: Alexander Lakhin, Dmitry Koval
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e85662df44ff47acdf5d2d413339445d60a9c30c
Modified Files
--------------
contrib/pg_visibility/Makefile | 1 +
contrib/pg_visibility/meson.build | 4 ++
contrib/pg_visibility/pg_visibility.c | 68 ++++++++++++++++++++--
.../pg_visibility/t/001_concurrent_transaction.pl | 47 +++++++++++++++
src/backend/storage/ipc/procarray.c | 13 ++++-
src/include/storage/standby.h | 2 +
6 files changed, 129 insertions(+), 6 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix false reports in pg_visibility
In-Reply-To: <E1rkjDR-003kjA-SN@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox