pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor initial hash lookup in dynahash.c
Date: Thu, 14 Mar 2024 22:57:32 +0000
Message-ID: <E1rku0y-003p5Q-GF@gemulon.postgresql.org> (raw)

Refactor initial hash lookup in dynahash.c

The same pattern is used three times in dynahash.c to retrieve a bucket
number and a hash bucket from a hash value.  This has popped up while
discussing improvements for the type cache, where this piece of
refactoring would become useful.

Note that hash_search_with_hash_value() does not need the bucket number,
just the hash bucket.

Author: Teodor Sigaev
Reviewed-by: Aleksander Alekseev, Michael Paquier
Discussion: https://postgr.es/m/5812a6e5-68ae-4d84-9d85-b443176966a1@sigaev.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cc5ef90edd809eaf85e11a0ee251229bbf7ce798

Modified Files
--------------
src/backend/utils/hash/dynahash.c | 75 +++++++++++++++++----------------------
1 file changed, 33 insertions(+), 42 deletions(-)



Message-ID: <E1rku0y-003p5Q-GF@gemulon.postgresql.org>
Permalink:  ../E1rku0y-003p5Q-GF@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1rku0y-003p5Q-GF@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Refactor initial hash lookup in dynahash.c
  In-Reply-To: <E1rku0y-003p5Q-GF@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox